Matthias Clasen [Tue, 15 Jun 2021 17:32:31 +0000 (13:32 -0400)]
Add a mnemonic testcase
Add a testcase that tests the label mnemonic handling
that was fixed in the previous commit.
Matthias Clasen [Tue, 15 Jun 2021 17:06:10 +0000 (13:06 -0400)]
label: Fix mnemonic handling
We were not handling the case right in which we
want to use underlines, but not use markup. Since
we are now using pango_parse_markup for this case,
we need to escape the xml markup.
Fixes: #4041
Matthias Clasen [Tue, 15 Jun 2021 11:37:57 +0000 (07:37 -0400)]
Revert "progressbar: Avoid redundant storage"
This reverts commit
95747b1a4082709d8e5320dc2171a8c53cedce19.
This was wrong - it turns out that while GtkProgressBar
allows you to change its orientation, its box layout is
always vertical.
Fixes: #4037
Emin Tufan Çetin [Tue, 15 Jun 2021 09:02:34 +0000 (09:02 +0000)]
Update Turkish translation
Matthias Clasen [Mon, 14 Jun 2021 19:20:06 +0000 (19:20 +0000)]
Merge branch 'macos-input-method' into 'master'
fix: make input method work again in gtk4
Closes #3968
See merge request GNOME/gtk!3668
Matthias Clasen [Mon, 14 Jun 2021 18:44:10 +0000 (18:44 +0000)]
Merge branch 'media-stream-name-collision' into 'master'
mediastream: Rename an api to avoid name collisions
Closes #4023
See merge request GNOME/gtk!3667
Zhi [Mon, 14 Jun 2021 16:06:35 +0000 (00:06 +0800)]
fix: make the new nsview as the first responder.
Make the new view as the first responder(focused) so the new view can
accept events from input method.
Fixes #3968.
Matthias Clasen [Mon, 14 Jun 2021 11:25:06 +0000 (07:25 -0400)]
mediastream: Rename an api to avoid name collisions
Some bindings can't handle the coexistence of
GtkMediaStream:prepared and gtk_media_stream_prepared.
Help them out by renaming the function to
gtk_media_stream_set_prepared, and rename
gtk_media_stream_unprepared as well, to match.
The existing entry points still exist, deprecated.
Update all internal uses.
Fixes: #4023
Matthias Clasen [Mon, 14 Jun 2021 10:39:43 +0000 (10:39 +0000)]
Merge branch 'columnview-double-activation' into 'master'
listitemwidget: Claim gesture when activating
Closes #4015
See merge request GNOME/gtk!3663
Matthias Clasen [Sun, 13 Jun 2021 12:03:39 +0000 (08:03 -0400)]
listitemwidget: Claim gesture when activating
Claim the gesture when we are activating a list item.
Otherwise we end up with double activations in
columnviews: first GtkColumnViewCell handles
the event, and then GtkListItemWidget handles
it again.
Fixes: #4015
Matthias Clasen [Sun, 13 Jun 2021 12:02:06 +0000 (08:02 -0400)]
listitemwidget: Match activation conditions
Make the conditions used for activation in the single-
and double-click case properly match, so that it is
obvious that we won't trigger both of them.
Matthias Clasen [Sun, 13 Jun 2021 11:38:50 +0000 (11:38 +0000)]
Merge branch 'filename-annotations' into 'master'
Add type annotations for filename arguments
Closes #633
See merge request GNOME/gtk!3665
Matthias Clasen [Sun, 13 Jun 2021 11:38:22 +0000 (11:38 +0000)]
Merge branch 'msvc-fix' into 'master'
Fix illegal instruction crash on x64 CPUs without POPCNT instruction when compiled with MSVC
See merge request GNOME/gtk!3664
Sebastian Cherek [Sat, 12 Jun 2021 17:35:13 +0000 (17:35 +0000)]
Update gtkpopcountprivate.h: undefined macro outside msvc
scherek [Sat, 12 Jun 2021 17:10:11 +0000 (19:10 +0200)]
Dropped defined() for readability
scherek [Sat, 12 Jun 2021 15:32:19 +0000 (17:32 +0200)]
Replaced && with || for POPCNT checks to fix the logic.
Matthias Clasen [Sat, 12 Jun 2021 15:12:06 +0000 (11:12 -0400)]
Add type annotations for filename arguments
Add missing "(type filename)" annotations for string
arguments that are filenames.
Fixes: #633
scherek [Sat, 12 Jun 2021 14:18:26 +0000 (16:18 +0200)]
Fix illegal instruction crash on x64 CPUs without POPCNT instruction when compiled with MSVC
Matthias Clasen [Fri, 11 Jun 2021 19:56:06 +0000 (19:56 +0000)]
Merge branch 'listmodel-get-item' into 'master'
docs: Mention the GtkWidget.destroy vfunc
Closes #4024
See merge request GNOME/gtk!3662
Matthias Clasen [Fri, 11 Jun 2021 19:38:20 +0000 (15:38 -0400)]
Add tests for empty list models
Test that all our models return NULL for out-of-range
get_item calls, as expected.
Matthias Clasen [Fri, 11 Jun 2021 19:37:16 +0000 (15:37 -0400)]
selectionfiltermodel: Fix an oversight
When the position is out of range, get_item needs
to return NULL.
Fixes: #4024
Matthias Clasen [Fri, 11 Jun 2021 14:11:53 +0000 (10:11 -0400)]
docs: Mention the GtkWidget.destroy vfunc
Mention GtkWidget.destroy in the migration guide.
Matthias Clasen [Fri, 11 Jun 2021 11:52:30 +0000 (07:52 -0400)]
docs: Fix a typo in the migration guide
Matthias Clasen [Thu, 10 Jun 2021 21:31:47 +0000 (21:31 +0000)]
Merge branch 'wip/chergert/fix-delayed-focus' into 'master'
window: clear move_focus when focus is already set
See merge request GNOME/gtk!3658
Christian Hergert [Thu, 10 Jun 2021 21:01:41 +0000 (14:01 -0700)]
window: clear move_focus when focus is already set
This can get set in other places, so we need to ensure it is cleared so
that an after-paint handler does not move the focus to a new widget.
Matthias Clasen [Thu, 10 Jun 2021 13:30:25 +0000 (13:30 +0000)]
Merge branch 'actionable-fixes' into 'master'
tests: Fix check vs toggle button confusion
Closes #4022
See merge request GNOME/gtk!3656
Matthias Clasen [Thu, 10 Jun 2021 12:37:13 +0000 (08:37 -0400)]
checkbutton: Fix actionable state tracking
If we have a GAction as model, we just have to
call gtk_action_helper_activate() and let
the action helper handle the state updates,
Fixes: #4022
Matthias Clasen [Thu, 10 Jun 2021 12:36:08 +0000 (08:36 -0400)]
togglebutton: Fix actionable state tracking
If we have a GAction as model, we just have to let
the action helper handle the state updates. GtkButton
already calls gtk_action_helper_activate() for us.
Matthias Clasen [Thu, 10 Jun 2021 12:35:24 +0000 (08:35 -0400)]
button: Add a private getter for the action helper
GtkToggleButton needs to know if it needs to actively
maintain its state, or defer to the action helper.
Matthias Clasen [Thu, 10 Jun 2021 12:10:25 +0000 (08:10 -0400)]
testgaction: Add more widgetry
Add some toggle and check buttons to test that they
work as expected as GtkActionables.
Matthias Clasen [Thu, 10 Jun 2021 11:55:45 +0000 (07:55 -0400)]
Fix the GAction test
We weren't setting the state of the stateful actions.
Matthias Clasen [Thu, 10 Jun 2021 11:49:08 +0000 (07:49 -0400)]
tests: Fix check vs toggle button confusion
Check buttons aren't toggle buttons anymore.
Matthias Clasen [Wed, 9 Jun 2021 22:23:47 +0000 (18:23 -0400)]
4.3.1
Matthias Clasen [Wed, 9 Jun 2021 17:30:02 +0000 (17:30 +0000)]
Merge branch 'ebassi/docs-for-master' into 'master'
docs: Mention Window::close-request in the migration guide
See merge request GNOME/gtk!3655
Emmanuele Bassi [Wed, 9 Jun 2021 17:11:10 +0000 (18:11 +0100)]
docs: Mention the ::damage-event signal in the migration guide
There is no replacement for damage event tracking.
Emmanuele Bassi [Wed, 9 Jun 2021 17:08:31 +0000 (18:08 +0100)]
docs: Mention GdkSurface:mapped
It replaces the ::map-event and ::unmap-event signals on GtkWidget.
Emmanuele Bassi [Wed, 9 Jun 2021 17:03:12 +0000 (18:03 +0100)]
docs: Mention Window::close-request in the migration guide
The Widget::delete-event signal was moved to Window::close-request.
Matthias Clasen [Wed, 9 Jun 2021 12:59:46 +0000 (12:59 +0000)]
Merge branch 'ci-install-build' into 'master'
Make a standalone hello world
See merge request GNOME/gtk!3652
Matthias Clasen [Wed, 9 Jun 2021 11:10:13 +0000 (07:10 -0400)]
ci: Update the image
v32 of the image includes wayland-protocols 1.21, and
other updates from Fedora 34.
While we are at it, drop gtk-doc from the image, and drop
the separate DOCS_IMAGE - no longer used.
Matthias Clasen [Wed, 9 Jun 2021 11:35:25 +0000 (07:35 -0400)]
ci: Collect hello build logs
Matthias Clasen [Tue, 8 Jun 2021 21:39:34 +0000 (17:39 -0400)]
ci: Test building against installed GTK
This is meant to ensure that we e.g. install the
right header files, and so on.
Matthias Clasen [Tue, 8 Jun 2021 21:26:36 +0000 (17:26 -0400)]
Make a standalone hello world
We want to test building against the installed GTK
in ci, so lets add a standalone project.
Matthias Clasen [Tue, 8 Jun 2021 17:17:45 +0000 (17:17 +0000)]
Merge branch 'row-activated-annotation' into 'master'
treeview: Add a few missing annotations
Closes #3828
See merge request GNOME/gtk!3647
Matthias Clasen [Tue, 8 Jun 2021 14:54:26 +0000 (14:54 +0000)]
Merge branch 'wip/carlosg/spin-button-swipe-gesture' into 'master'
spinbutton: Connect swipe gesture to the text entry
Closes #4008
See merge request GNOME/gtk!3649
Zhi [Sun, 6 Jun 2021 15:39:43 +0000 (23:39 +0800)]
fix: replace deprecated metods.
Use NSInputContext to replace NSInputManager, which has been deprecated
since 10.6.
Sync from
0e30a96 in gtk3.
Carlos Garnacho [Tue, 8 Jun 2021 13:09:37 +0000 (15:09 +0200)]
spinbutton: Mind the step in the swipe gesture
The swipe gesture forces values in the spin button that are
"impossible" according to the adjustment. This can break things
in creative ways.
Ensure the steps provided are always multiples of the adjustment
step value, and keep the remainder for further interaction.
Carlos Garnacho [Tue, 8 Jun 2021 13:06:29 +0000 (15:06 +0200)]
spinbutton: Connect swipe gesture to the text entry
In the GTK3 days, the spin button was an entry, with buttons on
top, and the swipe gesture affected the input on the entry bits.
Now the spin button is a container, so this gesture in the capture
phase applies to all contained children (incl. buttons).
Attach this gesture to the entry itself, so the buttons are left
outside this business. The gesture is still in the capture phase
in order to prevent text selection/edition/etc to happen.
Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/4008
Matthias Clasen [Tue, 8 Jun 2021 12:59:57 +0000 (12:59 +0000)]
Apply 1 suggestion(s) to 1 file(s)
Matthias Clasen [Tue, 8 Jun 2021 12:59:38 +0000 (12:59 +0000)]
Apply 1 suggestion(s) to 1 file(s)
Matthias Clasen [Tue, 8 Jun 2021 12:09:01 +0000 (12:09 +0000)]
Merge branch 'password-entry-buffer' into 'master'
Install gtkpasswordentrybuffer.h
See merge request GNOME/gtk!3646
Matthias Clasen [Tue, 8 Jun 2021 11:57:55 +0000 (07:57 -0400)]
treeview: Documentation tweaks
Matthias Clasen [Tue, 8 Jun 2021 11:49:06 +0000 (07:49 -0400)]
Install gtkpasswordentrybuffer.h
Matthias Clasen [Tue, 8 Jun 2021 11:25:12 +0000 (11:25 +0000)]
Merge branch 'password-entry-buffer' into 'master'
Make GtkPasswordEntryBuffer public
See merge request GNOME/gtk!3645
Matthias Clasen [Tue, 8 Jun 2021 11:25:11 +0000 (11:25 +0000)]
Make GtkPasswordEntryBuffer public
Matthias Clasen [Mon, 7 Jun 2021 18:10:12 +0000 (18:10 +0000)]
Merge branch 'ebassi/issue-3892' into 'master'
a11y: Update the level property for tree expanders
Closes #3892
See merge request GNOME/gtk!3470
Emmanuele Bassi [Mon, 7 Jun 2021 14:53:04 +0000 (14:53 +0000)]
Merge branch 'glib-main' into 'master'
subprojects: Use GLib main branch
See merge request GNOME/gtk!3642
Philip Withnall [Mon, 7 Jun 2021 13:56:49 +0000 (14:56 +0100)]
subprojects: Use GLib main branch
GLib upstream has renamed its `master` branch to `main`.
See https://gitlab.gnome.org/GNOME/glib/-/issues/2348.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
Matthias Clasen [Sun, 6 Jun 2021 12:24:52 +0000 (08:24 -0400)]
treeview: Add a few missing annotations
gtk_tree_view_row_activated and the ::row-activated signal
can (and do) receive NULL for the column occasionally.
This is an introspection api change.
Fixes: #3828
Matthias Clasen [Sat, 5 Jun 2021 22:13:21 +0000 (22:13 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Docs: Tweaks
Closes #3638
See merge request GNOME/gtk!3639
Matthias Clasen [Sat, 5 Jun 2021 21:56:35 +0000 (17:56 -0400)]
gtk-builder-tool: Replace can-focus with focusable
The focusable property has the meaning that can-focus had
in GTK 3.
Update tests, and mention this in the migration guide.
Fixes: #3638
Matthias Clasen [Sat, 5 Jun 2021 21:36:02 +0000 (17:36 -0400)]
Docs: Tweaks
Remove some more redundant "or NULL" blurbs.
Matthias Clasen [Sat, 5 Jun 2021 21:36:06 +0000 (21:36 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
popovermenu: doc tweaks
See merge request GNOME/gtk!3638
Matthias Clasen [Sat, 5 Jun 2021 21:19:39 +0000 (17:19 -0400)]
popovermenu: doc tweaks
Matthias Clasen [Sat, 5 Jun 2021 13:36:10 +0000 (13:36 +0000)]
Merge branch 'submenu-action-fixes' into 'master'
Submenu action fixes
Closes #3721
See merge request GNOME/gtk!3272
Matthias Clasen [Sat, 5 Jun 2021 13:05:15 +0000 (13:05 +0000)]
Merge branch 'msvc-aarch64' into 'master'
gtkpopcountprivate.h: Fix build on ARM/aarch64 Visual Studio
See merge request GNOME/gtk!3637
Matthias Clasen [Mon, 8 Mar 2021 05:43:43 +0000 (00:43 -0500)]
menusectionbox: Fix submenu-action for nested menus
We were not updating the state of submenu-actions
for nested submenus.
Fixes: #3721
Matthias Clasen [Mon, 8 Mar 2021 05:46:30 +0000 (00:46 -0500)]
popovermenubar: Make submenu-actions work
We were not updating submenu-action state
for items in menubars.
Matthias Clasen [Mon, 8 Mar 2021 05:45:35 +0000 (00:45 -0500)]
menutrackeritem: Make submenu-actions work again
This broke when GtkActionMuxer stopped being a
GActionGroup.
Matthias Clasen [Mon, 8 Mar 2021 05:43:03 +0000 (00:43 -0500)]
bloatpad: Bring back the menubar
This was lost at some point.
Matthias Clasen [Sat, 5 Jun 2021 12:47:08 +0000 (12:47 +0000)]
Merge branch 'powimod_icon' into 'master'
Load icon from executable on Windows
Closes #3713
See merge request GNOME/gtk!3326
Chun-wei Fan [Sat, 5 Jun 2021 07:37:52 +0000 (15:37 +0800)]
gtkpopcountprivate.h: Fix build on ARM/aarch64 Visual Studio
__popcnt() is not supported for ARM nor ARM64 Visual Studio builds, so we must
use the fallback implementation as intrinsics are not supported for this
purpose on ARM/ARM64 Visual Studio builds.
Matthias Clasen [Sat, 5 Jun 2021 01:47:24 +0000 (01:47 +0000)]
Merge branch 'ci-file-filters' into 'master'
GtkFileFilter: Allow case-insensitive patterns
Closes #3705
See merge request GNOME/gtk!359
Matthias Clasen [Sat, 5 Jun 2021 01:19:39 +0000 (01:19 +0000)]
Merge branch 'imcontext-ignore-more-keysyms' into 'master'
imcontext: Ignore more keysyms
See merge request GNOME/gtk!3634
Matthias Clasen [Fri, 4 Jun 2021 22:34:01 +0000 (18:34 -0400)]
Add GtkFileFilter tests
Matthias Clasen [Fri, 4 Jun 2021 03:55:48 +0000 (23:55 -0400)]
GtkFileFilter: Add suffix matches
This is less flexible than a glob pattern, but it is
explicitly case-insensitive, to match the behavior
on Windows.
Fixes: #3705
Matthias Clasen [Fri, 4 Jun 2021 03:50:09 +0000 (23:50 -0400)]
Add a helper to make case-insensitive globs
This will be used in GtkFileFilter in the future.
Tests included.
Matthias Clasen [Fri, 4 Jun 2021 23:01:57 +0000 (19:01 -0400)]
imcontext: Ignore more keysyms
It finally dawned on my that #3673 is just another
case of unexpected keysyms getting sent our way via
fringe XKB features.
Ignore them all!
Matthias Clasen [Fri, 4 Jun 2021 20:24:23 +0000 (20:24 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
docs: Mention <packing> in migration guide
Closes #3950 and #2271
See merge request GNOME/gtk!3630
Matthias Clasen [Fri, 4 Jun 2021 20:24:09 +0000 (20:24 +0000)]
Merge branch 'master' into 'matthiasc/for-master'
# Conflicts:
# docs/reference/gtk/migrating-3to4.md
Matthias Clasen [Fri, 4 Jun 2021 13:47:26 +0000 (09:47 -0400)]
icontheme: Add detail to the 'not found' message
Name the icon theme we're using.
Fixes: #2271
Matthias Clasen [Fri, 4 Jun 2021 12:58:12 +0000 (08:58 -0400)]
Clean up some comments
These XXX comments aren't useful enough to keep.
Matthias Clasen [Fri, 4 Jun 2021 12:44:37 +0000 (08:44 -0400)]
Add a doc comment for gsk_rounded_rect_is_circular
Matthias Clasen [Fri, 4 Jun 2021 13:21:37 +0000 (13:21 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
docs: Mention <packing> in migration guide
Closes #3950
See merge request GNOME/gtk!3629
Matthias Clasen [Fri, 4 Jun 2021 12:29:23 +0000 (08:29 -0400)]
wayland: Add a comment
I just had to debug this to rediscover how it works, so
add a comment for next time.
Matthias Clasen [Fri, 4 Jun 2021 12:29:23 +0000 (08:29 -0400)]
wayland: Add a comment
I just had to debug this to rediscover how it works, so
add a comment for next time.
Matthias Clasen [Fri, 4 Jun 2021 12:06:18 +0000 (08:06 -0400)]
docs: Escape some xml tags
When mentioning xml tags in markdown, we must write
them as `<foo>`, or they will come out mangled.
Matthias Clasen [Fri, 4 Jun 2021 11:41:25 +0000 (07:41 -0400)]
docs: Mention <packing> in migration guide
Add another hint for what to do with child properties.
Fixes: #3950
Matthias Clasen [Fri, 4 Jun 2021 11:41:25 +0000 (07:41 -0400)]
docs: Mention <packing> in migration guide
Add another hint for what to do with child properties.
Fixes: #3950
Matthias Clasen [Fri, 4 Jun 2021 04:43:20 +0000 (04:43 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
fnmatch: Support case-folding
See merge request GNOME/gtk!3628
Matthias Clasen [Fri, 4 Jun 2021 04:02:48 +0000 (04:02 +0000)]
Merge branch 'gtk_combo_box_with_entry_docs_update' into 'master'
Documentation update for combo_box_new_with_entry
See merge request GNOME/gtk!3605
DarkTrick [Fri, 4 Jun 2021 04:02:48 +0000 (04:02 +0000)]
Documentation update for combo_box_new_with_entry
Matthias Clasen [Fri, 4 Jun 2021 03:33:33 +0000 (23:33 -0400)]
Move fnmatch testcases to the testsuite
We have a well-working way to test internal
apis now, lets use it for these tests.
Matthias Clasen [Fri, 4 Jun 2021 03:55:30 +0000 (23:55 -0400)]
fnmatch: Support case-folding
This will be used in GtkFileFilter in the future.
Update all callers.
Matthias Clasen [Fri, 4 Jun 2021 02:45:25 +0000 (02:45 +0000)]
Merge branch 'bilelmoussaoui/markdown-links' into 'master'
docs: use markdown syntax for hyperlinks
See merge request GNOME/gtk!3589
Matthias Clasen [Fri, 4 Jun 2021 02:21:33 +0000 (02:21 +0000)]
Merge branch 'GtkCellLayoutWordingImprovement' into 'master'
Added information, that "attributes" refer to CellRenderer "properties".
See merge request GNOME/gtk!3602
DarkTrick [Fri, 4 Jun 2021 02:21:31 +0000 (02:21 +0000)]
Added information, that "attributes" refer to CellRenderer "properties".
Matthias Clasen [Fri, 4 Jun 2021 02:01:53 +0000 (02:01 +0000)]
Merge branch 'fix-appwindow-allocate' into 'master'
applicationwindow: Allocate tooltips
Closes #3997
See merge request GNOME/gtk!3627
Matthias Clasen [Fri, 4 Jun 2021 01:53:12 +0000 (01:53 +0000)]
Apply 1 suggestion(s) to 1 file(s)
Matthias Clasen [Fri, 4 Jun 2021 01:43:13 +0000 (21:43 -0400)]
applicationwindow: Allocate tooltips
GtkApplicationWindows size_allocate does not chain
up if the menubar is visible; don't forget to allocate
the tooltip window in that case.
Fixes: #3997
Matthias Clasen [Thu, 3 Jun 2021 21:59:26 +0000 (21:59 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Cosmetics: Eradicate gdouble
See merge request GNOME/gtk!3626